feat: lint and pre-commit hook with Husky and eslint #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
Sembauke
force-pushed
the
feat/lint-and-precommit-hook
branch
2 times, most recently
from
a33e647
to
7de03f1
Compare
Our prop types are fine, but eslint-react isn't detecting them correctly. With a little help jsx-eslint/eslint-plugin-react#3284 (comment) we can tell it what the props are.
Same principle as the main repo: if we care enough for something to be a rule, we want CI to tell us when it's not being followed.
|
@huyenltnguyen I had to fix a few errors, but nothing that required me to change the functionality, just types. I hope that's okay! If I messed anything up, please let me know/push a commit. |
ojeytonwilliams
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks for putting this together, @Sembauke.
I made a few tweaks, so I'll explain the justification:
- Similarly to the main repo, treat eslint warnings as errors (otherwise they're likely to be ignored)
- Use recommended rules for all plugins. They're generally good defaults, so we should use them until we have a reason not to
- Add
eslint .tolintscript. Otherwise CI will not run it.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #XXXXX